Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@shiftkey
Copy link
Contributor

@shiftkey shiftkey commented Feb 5, 2019

Closes #133

node-abi now has support for the correct v4 Electron ABI electron/node-abi@9e4c1a6

This PR updates us to use that package and adds 4.0.4 as a target - after running npm run prebuild-electron locally I got an additional package with then new v69 ABI, ready to go:

$ ls prebuilds                                                                                                                            
keytar-v4.3.1-electron-v53-darwin-x64.tar.gz	keytar-v4.3.1-electron-v57-darwin-x64.tar.gz	keytar-v4.3.1-electron-v69-darwin-x64.tar.gz
keytar-v4.3.1-electron-v54-darwin-x64.tar.gz	keytar-v4.3.1-electron-v64-darwin-x64.tar.gz

@shiftkey shiftkey changed the title upgrade node-abi and prebuild for newest v4 with correct ABI upgrade node-abi and prebuild for newest v4 with correct Electron ABI Feb 5, 2019
@shiftkey shiftkey requested a review from daviwil February 5, 2019 13:17
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@shiftkey shiftkey merged commit 5840824 into master Feb 5, 2019
@shiftkey shiftkey deleted the upgrade-node-abi branch February 5, 2019 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants