This repository was archived by the owner on Dec 15, 2022. It is now read-only.
upgrade node-abi and prebuild for newest v4 with correct Electron ABI #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133
node-abinow has support for the correct v4 Electron ABI electron/node-abi@9e4c1a6This PR updates us to use that package and adds
4.0.4as a target - after runningnpm run prebuild-electronlocally I got an additional package with then newv69ABI, ready to go: