Resolve numpad differently to avoid conflict with Windows unicode entry

[Ben3eeE]

Description of the Change

Windows uses Alt-numpad to insert unicode characters. atom-keymap currently resolves the numpad digits the same was as the numeric row which means that unicode entry will conflict with Alt-number bound keys. Alt-number is bound to pane-show-item-[number] which means you can't use Alt-numpad to enter unicode characters in Atom without changing pane items.

This changes the numpad digits to resolve to numpad[number] instead of just [number] by using KeyboardEvent.code when numlock is on to avoid conflict. Windows seems to still allow unicode entry when numlock is off which would conflict with keybindings but this seems to be the expected behavior on Windows after testing it in some common programs.

Alternate Designs

Benefits

Fixes #147 and allows us to enter unicode characters with the numpad on Windows without conflicting with Atoms default set of keybindings.

Possible Drawbacks

• Someone relies on the current way we resolve keys
• This adds the change for all platforms. I don't know if this makes sense of Linux or mac. Linux seems to use a different method to insert unicode characters.

Applicable Issues

Fixes #147

[winstliu]

I think alt-numpad is a Windows-only thing.

[nathansobo]

I see this but may not have time to get to it this week. Adding it to my list.

[nathansobo]

👍 Nice work. Sorry for the delay in reviewing. Feel free to merge, publish, and upgrade on the master branch of atom/atom.

[Ben3eeE]

I have no idea how to publish 😆

[nathansobo]

• On the master branch after you've pulled your changes:
  • npm version patch
  • git push && git push --tags && npm publish
• In Atom, upgrade the dependency to your new version in package.json, commit with :arrow_up: atom-keymap and push.

[lydell]

Here’s a Linux guy that got bitten by this :)

https://discuss.atom.io/t/1-16-handles-numpad-differently-compared-to-1-15/42681

In short, I’ve remapped the numpad keys to other keys, but since atom now uses event.code for the numpad keys that’s not honored.

Here’s my workaround: lydell/dotfiles@c871a37

It might also be worth looking into why this wasn’t mentioned in the 1.16 changelog.

Not sure if this PR should only be applied to Windows only or if I’m this guy: https://xkcd.com/1172/