Skip to content

refactor(creature): replace polling-based pathfinding with event-driven follow system #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ramon-bernardo wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

refactor(creature): replace polling-based pathfinding with event-driven follow system #183

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e43276f
fix(creature): follow pathing and default follow state
ramon-bernardo Feb 15, 2026
00c7e51
fix: bot suggestions
ramon-bernardo Feb 15, 2026
3b44341
refactor: remove unused var
ramon-bernardo Feb 15, 2026
e542a1a
fix: creature pathfinding
ramon-bernardo Feb 15, 2026
3864e5e
fix: schedule follow path
ramon-bernardo Feb 15, 2026
1c66f70
fix: schedule follow path
ramon-bernardo Feb 15, 2026
2f2c916
fix: bot suggestions
ramon-bernardo Feb 15, 2026
d888e1b
fix: schedule follow path
ramon-bernardo Feb 15, 2026
e26c673
fix: move on no-path
ramon-bernardo Feb 16, 2026
732e220
fix: remove virtual method
ramon-bernardo Feb 17, 2026
f0c7e21
feat: check follow when not path
ramon-bernardo Feb 17, 2026
7676f76
fix: prevent reschedule task
ramon-bernardo Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/creature.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ void Creature::onThink(uint32_t interval)

void Creature::forceUpdatePath()
{
if (attackedCreature.expired() && followCreature.expired()) {
if (followCreature.expired()) {
return;
}

Expand Down Expand Up @@ -688,15 +688,12 @@ void Creature::setAttackedCreature(const std::shared_ptr<Creature>& creature)
}

attackedCreature = creature;
creature->addFollower(asCreature());
onAttackedCreature(creature);

if (const auto& player = creature->asPlayer()) {
player->addInFightTicks();
}

forceUpdatePath();

for (const auto& summon : summons | tfs::views::lock_weak_ptrs) {
summon->setAttackedCreature(creature);
}
Expand Down Expand Up @@ -740,15 +737,24 @@ void Creature::setFollowCreature(const std::shared_ptr<Creature>& creature)
return;
}

followCreature = creature;
if (const auto& oldFollow = getFollowCreature()) {
oldFollow->removeFollower(asCreature());
}
creature->addFollower(asCreature());

followCreature = creature;
hasFollowPath = false;
onFollowCreature(creature);

forceUpdatePath();
}

void Creature::removeFollowCreature()
{
if (const auto& oldFollow = getFollowCreature()) {
oldFollow->removeFollower(asCreature());
}

followCreature.reset();
onUnfollowCreature();
}
Expand Down
Loading