Skip to content

Conversation

@Blacksmoke16
Copy link
Member

Context

Little refactor to allow centralizing service tag processing. Tags are collected as raw values, then normalized into the final hash format via a dedicated compiler pass.

Changelog

  • Centralize tag processing

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ency_injection/src/compiler_passes/process_tags.cr 96.00% 0 Missing and 1 partial ⚠️
Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.21% <ø> (ø)
dependency_injection 92.04% <96.96%> (+0.09%) ⬆️
dotenv 98.41% <ø> (ø)
event_dispatcher 95.90% <ø> (ø)
framework 97.24% <ø> (ø)
http 98.94% <ø> (ø)
image_size 96.63% <ø> (ø)
mercure 94.94% <ø> (ø)
mime 99.37% <ø> (ø)
negotiation 97.93% <ø> (ø)
routing 98.38% <ø> (ø)
serializer 95.86% <ø> (ø)
spec 94.06% <ø> (ø)
validator 95.85% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit 5ebe97e into master Dec 31, 2025
15 of 16 checks passed
@Blacksmoke16 Blacksmoke16 deleted the centralized-tag-processing branch December 31, 2025 21:17
PallasAthenaie pushed a commit to athena-framework/dependency-injection that referenced this pull request Dec 31, 2025
## Context

Little refactor to allow centralizing service tag processing. Tags are
collected as raw values, then normalized into the final hash format via
a dedicated compiler pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants