Skip to content

Adding some graceful shutdown handling to ProtoActorLifecycleHost#1842

Merged
rogeralsing merged 1 commit intoasynkron:devfrom
jstnlef:hosted-service-cleanup
Nov 1, 2022
Merged

Adding some graceful shutdown handling to ProtoActorLifecycleHost#1842
rogeralsing merged 1 commit intoasynkron:devfrom
jstnlef:hosted-service-cleanup

Conversation

@jstnlef
Copy link
Contributor

@jstnlef jstnlef commented Nov 1, 2022

Description

Since the proto.actor cluster has the ability to shut itself down when other nodes in the system believe that it should be shutdown, I believe it makes sense for this to also trigger a process shutdown. Perhaps this should be made optional?

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@rogeralsing rogeralsing merged commit 3d4168c into asynkron:dev Nov 1, 2022
@jstnlef jstnlef deleted the hosted-service-cleanup branch November 1, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments