Prevent scheduled task cancelation from emitting error logs#1758
Merged
rogeralsing merged 1 commit intoasynkron:devfrom Sep 23, 2022
Merged
Prevent scheduled task cancelation from emitting error logs#1758rogeralsing merged 1 commit intoasynkron:devfrom
rogeralsing merged 1 commit intoasynkron:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying to cancel scheduled tasks with their corresponding
CancelationSource, I noticed error logs were constantly being emitted. The root cause of this turned out to be that the innerTask.Delayends up being the task that is canceled rather than the outerTask.runso it would always throw an exception. I'm fairly convinced that it isn't necessary to check since no caller could possibly have access to the running task to catch the cancelation exception anyway.Purpose
This pull request is a:
Checklist