fix: define react and react-dom as peerDependencies #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
bug
magicmatatjahu
requested review from
asyncapi-bot-eve,
derberg and
fmvilas
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
@derberg ping, ping :) |
derberg
approved these changes
Jul 4, 2022
Member
Author
|
/rtm |
Contributor
|
🎉 This PR is included in version 1.0.0-next.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
We use
reactandreact-domin component, but we don't have defined these packages as peer-dependencies and e.g. yarn throw error due to this fact. See more #609I tested package installing new project with yarn without and with
react/react-domdeps and yarn in first case throw errors, in second installation passed.Related issue(s)
Resolves #609