Skip to content

refactor: simplify system variable access in TriggerScheduleNode#9

Draft
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
refactor-trigger-schedule-node-system-variables-3325533844711015309
Draft

refactor: simplify system variable access in TriggerScheduleNode#9
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
refactor-trigger-schedule-node-system-variables-3325533844711015309

Conversation

@google-labs-jules
Copy link
Copy Markdown

Simplified system variable access in TriggerScheduleNode by removing the manual extraction and injection of system variables into the node's output. System variables are already available via the VariablePool, making this step redundant.

Changes:

  • Modified api/core/workflow/nodes/trigger_schedule/trigger_schedule_node.py to remove the loop that added system variables to outputs.
  • Removed unused import SYSTEM_VARIABLE_NODE_ID.

Verified with a new unit test (temporarily created and run) ensuring system variables are no longer in outputs but user inputs are preserved.


PR created automatically by Jules for task 3325533844711015309 started by @asukaminato0721

Removes the manual addition of system variables to outputs in TriggerScheduleNode, as they are globally accessible via the VariablePool. This aligns with consistent refactoring across node types.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 26, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants