refactor: Verify and improve DatasourceInput value type#4
refactor: Verify and improve DatasourceInput value type#4google-labs-jules[bot] wants to merge 5 commits into
Conversation
Updated `DatasourceInput.value` type hint from `Union[Any, list[str]]` to `Union[str, int, float, bool, list[str], None]` to be more specific and strictly validate inputs. Added unit tests to verify valid and invalid inputs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
fix the test |
The tests for the datasource input validation ( |
|
==================================== ERRORS ==================================== |
Thank you for the detailed error message. I see that the duplicate filename |
Updated `DatasourceInput.value` type hint from `Union[Any, list[str]]` to `Union[str, int, float, bool, list[str], None]` to be more specific and strictly validate inputs. Added unit tests to verify valid and invalid inputs. Renamed test file to avoid conflict.
|
I have added |
Updated `DatasourceInput.value` type hint from `Union[Any, list[str]]` to `Union[str, int, float, bool, list[str], None]` to be more specific and strictly validate inputs. Added unit tests to verify valid and invalid inputs. Renamed test file to avoid conflict. Added type assertion in `DatasourceNode._generate_parameters` to resolve static type check errors.
|
I have added another type assertion |
Updated `DatasourceInput.value` type hint from `Union[Any, list[str]]` to `Union[str, int, float, bool, list[str], None]` to be more specific and strictly validate inputs. Added unit tests to verify valid and invalid inputs. Renamed test file to avoid conflict. Added type assertions in `DatasourceNode` methods to resolve static type check errors.
|
Error: No release type found in pull request title "Verify and improve DatasourceInput value type". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
|
Acknowledged. I will update the PR title to follow the Conventional Commits specification. |
Updated `DatasourceInput.value` type hint from `Union[Any, list[str]]` to `Union[str, int, float, bool, list[str], None]` to be more specific and strictly validate inputs. Added unit tests to verify valid and invalid inputs. Renamed test file to avoid conflict. Added type assertions in `DatasourceNode` methods to resolve static type check errors.
Updated
DatasourceInput.valuetype hint inapi/core/workflow/nodes/datasource/entities.pytoUnion[str, int, float, bool, list[str], None]to improve type safety and validation.Added
api/tests/unit_tests/core/workflow/nodes/datasource/test_entities.pyto test various input types.PR created automatically by Jules for task 10692253656539910090 started by @asukaminato0721