-
-
Notifications
You must be signed in to change notification settings - Fork 13
Add plugin for cpu/memory intensive tests #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two new options need to be documented on README.
- When should one mark a test as slow or hugemem or both?
- How do you use these features?
- What if another plugin already registered these markers? Then what is the intended behavior? (Possible since "slow" is actually in official pytest example.)
|
Needs a change log too. Thanks! |
|
Maybe tests too or is that overkill? 🤷 |
No idea, but not it's an issue for all plugins I guess.
Ideally yes but I'm not sure how to do that. It works on the astropy PR so that's a good test for now :) |
|
I agree with @pllim that any new functionality here should be documented! I'm also unsure on what makes the most sense: having a |
|
Sure I can add some docs, just wanted to get the feelings before since names etc could change. |
I agree. I wouldn't want to run them by default myself. |
pllim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in so we can use it at astropy/astropy#12764 . Thanks!
|
This pull request is missing its change log entry. |
|
Ops, thanks for catching that. Added in 2d4ea39 . |
Related to astropy/astropy#12350
With this plugin, cpu/memory intensive tests
--run-slowand--run-hugemem-m slowand-n hugememIf you have better ideas for the marker names ...