Update minimum requirements #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous minimum required version was 2.0, and the minimum required pytest version is 4.6. However, pytest-cov versions up to (and including) 2.3.0 are incompatible with pytest starting from 4.0. The minimum version actually required by Astropy tests is 2.3.1. See pytest-dev/pytest-cov#125 for more details.
The previous minimum required version was 0.2.0. However, Astropy documentation testing makes use of the '+SHOW_WARNINGS' option, which was introduced by scientific-python/pytest-doctestplus#136 and therefore the actual minimum required pytest-doctestplus version is 0.9.0.
pllim
approved these changes
Jun 3, 2021
Member
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Good catch. Probably an oversight for when we released packages like pytest-doctestplus and forgot to update this meta-package. And given pip often pulls the latest releases anyway, we don't notice when the minversions get out of date. Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Astropy tests with pytest-doctestplus 0.8.0 or pytest-cov 2.3.0 results in failure. This pull request updates the requirements so that they correspond to reality. See the commit messages for more details.