Skip to content

Issue 78: 1X should be viewed as scalar#79

Merged
JulienPeloton merged 2 commits intomasterfrom
issues/78/oneElementVector
May 17, 2019
Merged

Issue 78: 1X should be viewed as scalar#79
JulienPeloton merged 2 commits intomasterfrom
issues/78/oneElementVector

Conversation

@JulienPeloton
Copy link
Copy Markdown
Member

@JulienPeloton JulienPeloton commented May 17, 2019

Following #78, this PR introduces new change to convert 1 element vector from FITS (1X) to a scalar in Spark (XType) and not array of one element:

# Example
 E -> float -> FloatType
1E -> float -> FloatType
nE -> array of n floats -> ArrayType(FloatType)

@JulienPeloton JulienPeloton added bug Something isn't working IO labels May 17, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented May 17, 2019

Codecov Report

Merging #79 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   90.24%   90.51%   +0.26%     
==========================================
  Files           9        9              
  Lines         533      548      +15     
  Branches      101       97       -4     
==========================================
+ Hits          481      496      +15     
  Misses         52       52
Impacted Files Coverage Δ
...scala/com/astrolabsoftware/sparkfits/FitsLib.scala 97.51% <100%> (ø) ⬆️
...la/com/astrolabsoftware/sparkfits/FitsSchema.scala 85.29% <100%> (+2.53%) ⬆️
...scala/com/astrolabsoftware/sparkfits/FitsHdu.scala 95% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dd75d...dda12ad. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working IO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants