Skip to content

Enable zlib-rs on all platforms#9202

Merged
charliermarsh merged 1 commit intomainfrom
charlie/ef
Nov 18, 2024
Merged

Enable zlib-rs on all platforms#9202
charliermarsh merged 1 commit intomainfrom
charlie/ef

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

@charliermarsh charliermarsh commented Nov 18, 2024

Summary

Let's see if these build now. They failed back when we had a CMake dependency, and had to build zlib-ng.

@charliermarsh charliermarsh added releases Related to building and distributing release artifacts of uv performance Potential performance improvement labels Nov 18, 2024
@charliermarsh charliermarsh marked this pull request as ready for review November 18, 2024 16:21
@charliermarsh charliermarsh merged commit 465588f into main Nov 18, 2024
@charliermarsh charliermarsh deleted the charlie/ef branch November 18, 2024 16:22
@musicinmybrain
Copy link
Copy Markdown
Contributor

musicinmybrain commented Nov 20, 2024

Is there any reason why uv should still be falling back to rust_backend on ppc64le, s390x, and FreeBSD?

[target.'cfg(not(any(target_arch = "s390x", target_arch = "powerpc64", target_os = "freebsd")))'.dependencies]
flate2 = { version = "1.0.28", default-features = false, features = ["zlib-rs"] }
[target.'cfg(any(target_arch = "s390x", target_arch = "powerpc64", target_os = "freebsd"))'.dependencies]
flate2 = { version = "1.0.28", default-features = false, features = ["rust_backend"] }

I assumed that was due to CMake build system portability issues with the zlib-ng backend, which should be gone with the switch to zlib-rs.

@charliermarsh
Copy link
Copy Markdown
Member Author

Ah no, sorry. We can probably remove that now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement releases Related to building and distributing release artifacts of uv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants