Skip to content

Include trampolines in sdist on Windows#9172

Merged
charliermarsh merged 1 commit intomainfrom
zb/sd-tr
Nov 18, 2024
Merged

Include trampolines in sdist on Windows#9172
charliermarsh merged 1 commit intomainfrom
zb/sd-tr

Conversation

@zanieb
Copy link
Copy Markdown
Member

@zanieb zanieb commented Nov 17, 2024 •
edited by charliermarsh
Loading

Naive fix for

         Compiling uv-trampoline-builder v0.0.1 (C:\Users\...\AppData\Local\uv\cache\sdists-v6\pypi\uv\0.5.2\9xswF03fJ5dr3vH_iowkm\src\crates\uv-trampoline-builder)
      error: couldn't read `crates\uv-trampoline-builder\src\../../uv-trampoline/trampolines/uv-trampoline-x86_64-gui.exe`: The system cannot find the path specified. (os error 3)
        --> crates\uv-trampoline-builder\src\lib.rs:21:5
         |
      21 |     include_bytes!("../../uv-trampoline/trampolines/uv-trampoline-x86_64-gui.exe");
         |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Closes: #9138.

@zanieb zanieb added the releases Related to building and distributing release artifacts of uv label Nov 17, 2024
@zanieb zanieb requested a review from konstin November 17, 2024 16:24
@charliermarsh charliermarsh added the windows Specific to the Windows platform label Nov 17, 2024
@charliermarsh
Copy link
Copy Markdown
Member

charliermarsh commented Nov 17, 2024

See: #9138

@dlech
Copy link
Copy Markdown

dlech commented Nov 17, 2024

Success!

> pipx install ~\Downloads\uv-0.5.2.tar.gz
  installed package uv 0.5.2, installed using Python 3.13.0
  These apps are now globally available
    - uv.exe
    - uvx.exe
done! ✨ 🌟 ✨
> uv --version
uv 0.5.2

@charliermarsh
Copy link
Copy Markdown
Member

charliermarsh commented Nov 17, 2024

Amazing, thanks @dlech.

@zanieb zanieb marked this pull request as ready for review November 17, 2024 17:48
@zanieb zanieb enabled auto-merge (squash) November 17, 2024 17:49
@charliermarsh charliermarsh merged commit 7e36bc1 into main Nov 18, 2024
@charliermarsh charliermarsh deleted the zb/sd-tr branch November 18, 2024 01:47
@BrewTestBot BrewTestBot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

@konstin konstin Awaiting requested review from konstin

Assignees

No one assigned

Labels

releases Related to building and distributing release artifacts of uv windows Specific to the Windows platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Failing to compile on Windows ARM64

3 participants

@zanieb @charliermarsh @dlech