Check in test script for uv run <url>#7708
Merged
BurntSushi merged 3 commits intoastral-sh:mainfrom Sep 26, 2024
Merged
Conversation
BurntSushi
requested changes
Sep 26, 2024
Member
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
This LGTM with a version pin and when CI passes. It looks like a Python lint violation?
scripts/uv-run-remote-script-test.py
Outdated
| # /// script | ||
| # requires-python = ">=3.11" | ||
| # dependencies = [ | ||
| # "rich", |
Member
There was a problem hiding this comment.
Can you do rich==13.8.1? Just so the dependency is pinned.
Member
Yeah that SGTM! |
zanieb
approved these changes
Sep 26, 2024
BurntSushi
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge before #6375 (see #6375 (comment))
This is testing a couple of things at once, and I'm happy to strip back to something more simple (i.e., "just" printing).
However, I figured it would be useful to ensure that the PEP 723 metadata correctly works as well as that
additional arguments are correctly forwarded to the Python program.
cc: @BurntSushi