Skip to content

Fix link-mode=clone on linux #7620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 2 commits into from
Sep 22, 2024
Merged

Fix link-mode=clone on linux #7620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e078a7b
Do not attempt to reflink directories on linux
aroig Sep 21, 2024
35a6e82
Update comment
aroig Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/install-wheel-rs/src/linker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,17 @@ fn clone_wheel_files(
let mut count = 0usize;
let mut attempt = Attempt::default();

// On macOS, directly can be recursively copied with a single `clonefile` call.
// On macOS, directories can be recursively copied with a single `clonefile` call.
// So we only need to iterate over the top-level of the directory, and copy each file or
// subdirectory unless the subdirectory exists already in which case we'll need to recursively
// merge its contents with the existing directory.
//
// On linux, we need to always reflink recursively, as `FICLONE` ioctl does not support directories.
// Also note, that reflink is only supported on certain filesystems (btrfs, xfs, ...), and only when
// it does not cross filesystem boundaries.
//
// On windows, we also always need to reflink recursively, as `FSCTL_DUPLICATE_EXTENTS_TO_FILE` ioctl
// is not supported on directories. Also, it is only supported on certain filesystems (ReFS, SMB, ...).
for entry in fs::read_dir(wheel.as_ref())? {
clone_recursive(
site_packages.as_ref(),
Expand Down Expand Up @@ -365,7 +372,7 @@ fn clone_recursive(

debug!("Cloning {} to {}", from.display(), to.display());

if cfg!(windows) && from.is_dir() {
if (cfg!(windows) || cfg!(target_os = "linux")) && from.is_dir() {
// On Windows, reflinking directories is not supported, so we copy each file instead.
fs::create_dir_all(&to)?;
for entry in fs::read_dir(from)? {
Expand Down