Conversation
konstin
added
the
enhancement
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
LGTM, although I think I would probably try to avoid defining a new trait here in favor of a concrete type or enum. (But I may be missing some context motivating the trait.)
| fn on_download_start(&self, name: &str, size: Option<u64>) -> usize; | ||
| fn on_download_progress(&self, id: usize, inc: u64); | ||
| fn on_download_complete(&self); | ||
| } |
There was a problem hiding this comment.
How come you went for a trait here instead of asking for a concrete type? An enum would probably do the job in order to handle the case of the "dummy" reporter.
There was a problem hiding this comment.
I think this matches our other reporter patterns?
There was a problem hiding this comment.
Ah. That would be a candidate for un-genericizing code in a hope to improve compile times. :)
(It may result in little gain if there's only one instantiation of the generics outside of tests though.)
There was a problem hiding this comment.
It would be nice to have a single reporter crate that is shared (or some callback) instead of copying this code for every new feature.
There was a problem hiding this comment.
Yeah. I think it can be completely monomorphic too with no parametric polymorphism.
konstin
force-pushed
the
konsti/publish2
branch
from
33562d6 to
8ea5a02
Compare
konstin
force-pushed
the
konsti/publish5
branch
from
fdce2be to
1fdc856
Compare
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
konstin
force-pushed
the
konsti/publish5
branch
from
1fdc856 to
ace6bae
Compare
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
konstin
force-pushed
the
konsti/publish2
branch
from
e4a765f to
7eed9bd
Compare
konstin
force-pushed
the
konsti/publish5
branch
from
ace6bae to
e4c838b
Compare
konstin
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
3 participants
Add progress bars to
uv publish, helpful when uploading large packages.