fix: correct inline suggestion for requirements.txt#6848
Closed
dimaqq wants to merge 1 commit intoastral-sh:mainfrom
Closed
fix: correct inline suggestion for requirements.txt#6848dimaqq wants to merge 1 commit intoastral-sh:mainfrom
dimaqq wants to merge 1 commit intoastral-sh:mainfrom
Conversation
Member
|
Thanks! I think we need to somehow make this dynamic based on the input command, since -r is correct for some commands (like uv pip install). |
Author
|
I'll happily leave this to maintainers, as my crab claws have barely moulted... |
Member
|
Hah, no worries @dimaqq. I'll try to finish it. |
Member
|
Fixed in #8112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #6845
Summary
Passing a requiremenst.txt file via
--withto uvx is wrong and there's a helpful inline suggestion to use xxxx instead.The suggestion was wrong, suggested
-rwhile the correct flag is--with-requirements.Test Plan
cargo run -- --helpto work around cargo run --bin uvx requires a manual step #6847cargo run --bin uvx -- --with test-requirements.txt toxor similarFull Disclosure
The "wrong" text was present in 4 lines of code and 1 assert, and so I've changes all 5 places.
I have no clue if all 5 places should have been changed. Maybe only some?
Please review 🙇🏻