Skip to content

fix: correct inline suggestion for requirements.txt#6848

Closed
dimaqq wants to merge 1 commit intoastral-sh:mainfrom
dimaqq:fix-requirements-inline-help
Closed

fix: correct inline suggestion for requirements.txt#6848
dimaqq wants to merge 1 commit intoastral-sh:mainfrom
dimaqq:fix-requirements-inline-help

Conversation

@dimaqq
Copy link
Copy Markdown

@dimaqq dimaqq commented Aug 30, 2024

Fixed #6845

Summary

Passing a requiremenst.txt file via --with to uvx is wrong and there's a helpful inline suggestion to use xxxx instead.

The suggestion was wrong, suggested -r while the correct flag is --with-requirements.

Test Plan

Full Disclosure

The "wrong" text was present in 4 lines of code and 1 assert, and so I've changes all 5 places.

I have no clue if all 5 places should have been changed. Maybe only some?

Please review 🙇🏻

@charliermarsh
Copy link
Copy Markdown
Member

Thanks! I think we need to somehow make this dynamic based on the input command, since -r is correct for some commands (like uv pip install).

@dimaqq
Copy link
Copy Markdown
Author

dimaqq commented Sep 2, 2024

I'll happily leave this to maintainers, as my crab claws have barely moulted...

@charliermarsh
Copy link
Copy Markdown
Member

Hah, no worries @dimaqq. I'll try to finish it.

@charliermarsh
Copy link
Copy Markdown
Member

Fixed in #8112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad inline suggestion for requirements.txt

2 participants