Support xz compressed packages#5513
Merged
charliermarsh merged 6 commits intoastral-sh:mainfrom Jul 28, 2024
Merged
Conversation
charliermarsh
added
the
compatibility
Member
|
Nice PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2187.
The xz backdoor is still fairly recent, but luckily the Rust
xz2crate bundles version 5.2.5 of the Cxzpackage, which is before the backdoor was introduced.It's worth noting that a security risk still exists if you have a compromised version of
xzinstalled on your system, but that risk is not introduced byuvor the Rust packages in general.Test Plan
Tried installing the package mentioned in the linked issue:
python-apt @ https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/python-apt/2.7.6/python-apt_2.7.6.tar.xz(Note that this will only work on Ubuntu - I tried on a Mac and while the archive was extracted properly, the package did not install because of some missing files)