Skip to content

Conversation

@slafs
Copy link
Contributor

@slafs slafs commented Apr 8, 2024

This is AFAICR my first contribution to a Rust-based codebase 🎉 . Be gentle please 😅.

Summary

Fixes #2900

Test Plan

Tried reproducing the steps described in #2900,
but with cargo run -- pip ... and it didn't crash 😄.

})?;
});

// silence MultipleHandlers error from ctrlc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should maybe mention something about why we're doing this 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I added a note.

@charliermarsh charliermarsh self-assigned this Apr 8, 2024
@charliermarsh charliermarsh added the bug Something isn't working label Apr 8, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) April 8, 2024 17:08
@charliermarsh charliermarsh merged commit f1630a7 into astral-sh:main Apr 8, 2024
@slafs slafs deleted the fix-2900-supress-multiple-ctrlc-handlers branch April 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uv panics when trying to create more than one RequirementsSource from a file without -r

2 participants