Add dedicated error message for direct filesystem paths in requirements#2369
Merged
charliermarsh merged 1 commit intomainfrom Mar 11, 2024
Merged
Add dedicated error message for direct filesystem paths in requirements#2369charliermarsh merged 1 commit intomainfrom
charliermarsh merged 1 commit intomainfrom
Conversation
charliermarsh
force-pushed
the
charlie/p
branch
from
7ea3244 to
8ece805
Compare
konstin
approved these changes
Mar 11, 2024
| }; | ||
|
|
||
| // Ex) `/bin/ls` | ||
| if first_char == '\\' || first_char == '/' || first_char == '.' { |
Member
There was a problem hiding this comment.
Does this support pip install path/to/my.whl? I suspect that this is a big fraction of the cases
Member
Author
There was a problem hiding this comment.
Yeah, that already works on main, because “path” is parsed as the package name, then we fail on the slash. The case covered in this PR is when there’s no leasing alpha character (like “./path”).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is analogous to #669, but for cases in which the package name is a filesystem path. In such cases, we'll fail when parsing the package name, since it doesn't start with a valid character, as opposed to failing when we go to parse the remaining version specifier.
Inspired by #2356.