Add env UV_SYSTEM_PYTHON as alias to --system#2354
Merged
charliermarsh merged 3 commits intoastral-sh:mainfrom Mar 11, 2024
Merged
Add env UV_SYSTEM_PYTHON as alias to --system#2354charliermarsh merged 3 commits intoastral-sh:mainfrom
charliermarsh merged 3 commits intoastral-sh:mainfrom
Conversation
charliermarsh
approved these changes
Mar 11, 2024
Member
charliermarsh
left a comment
charliermarsh
left a comment
There was a problem hiding this comment.
Thanks! I changed it to UV_SYSTEM_PYTHON, since UV_SYSTEM felt a little too generic. I know it deviates from the CLI but I think it's worth it.
konstin
changed the title
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
<!-- Thank you for contributing to uv! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary <!-- What's the purpose of the change? What does it do, and why? --> Fix left over after renaming UV_SYSTEM to UV_SYSTEM_PYTHON in #2354 CC @charliermarsh ## Test Plan <!-- How was it tested? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new env variable
UV_SYSTEMas alias for the cli argument--system.Use cases:
--systemflagchild containers nobody needs to know if you need the
--systemcliflag
venv. Both use some common scripts. Instead of adding duplicate or
special code to identify the dev container to set the
--systemflag,it would be nicer to set it via an env variable.
I'm unfamiliar with Rust and tried to add the support by looking at the
code.
Test Plan
I did test it manually
UV_SYSTEM_PYTHON=true uv pip install requests