Use rustls-tls with manual SSL_CERT_FILE implementation#2351
Closed
charliermarsh wants to merge 1 commit intomainfrom
Closed
Use rustls-tls with manual SSL_CERT_FILE implementation#2351charliermarsh wants to merge 1 commit intomainfrom
rustls-tls with manual SSL_CERT_FILE implementation#2351charliermarsh wants to merge 1 commit intomainfrom
Conversation
Member
|
Hm, that's a bummer. Can we toggle using system certificates with a flag instead and have it be off by default? I'm hesitant to require |
Member
Author
|
I can try that, yeah. |
Member
Author
|
Closing in favor of #2362. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is one solution to resolving #2346: use
rustls-tls, but continue to allowSSL_CERT_FILE.On my machine, it cuts simple commands dramatically.
On main:
On this branch:
I'm sure there are other considerations here but it's an option.