Skip to content

Use rustls-tls with manual SSL_CERT_FILE implementation#2351

Closed
charliermarsh wants to merge 1 commit intomainfrom
charlie/ssl
Closed

Use rustls-tls with manual SSL_CERT_FILE implementation#2351
charliermarsh wants to merge 1 commit intomainfrom
charlie/ssl

Conversation

@charliermarsh
Copy link
Copy Markdown
Member

Summary

This is one solution to resolving #2346: use rustls-tls, but continue to allow SSL_CERT_FILE.

On my machine, it cuts simple commands dramatically.

On main:

❯ echo "requests" | ./target/release/uv pip compile -
Resolved 5 packages in 123ms

On this branch:

❯ echo "requests" | ./target/release/uv pip compile -
Resolved 5 packages in 4ms

I'm sure there are other considerations here but it's an option.

@charliermarsh charliermarsh requested a review from zanieb March 11, 2024 02:17
@charliermarsh charliermarsh added the performance Potential performance improvement label Mar 11, 2024
@zanieb
Copy link
Copy Markdown
Member

zanieb commented Mar 11, 2024

Hm, that's a bummer. Can we toggle using system certificates with a flag instead and have it be off by default? I'm hesitant to require SSL_CERT_FILE and just using the system trust store is superior in a lot of cases. I'd maybe even suggest it be on by default... but the performance regression is pretty large.

@charliermarsh
Copy link
Copy Markdown
Member Author

I can try that, yeah.

@charliermarsh
Copy link
Copy Markdown
Member Author

Closing in favor of #2362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Potential performance improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants