Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/uv-auth/src/cache.rs
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ impl CredentialsCache {

let mut realms = self.realms.write().unwrap();

// Always replace existing entries if we have a password
if credentials.password().is_some() {
// Always replace existing entries if we have a password or token
if credentials.is_authenticated() {
return realms.insert(key, credentials.clone());
}

Expand Down
10 changes: 10 additions & 0 deletions crates/uv-auth/src/credentials.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ impl Credentials {
}
}

pub fn is_authenticated(&self) -> bool {
match self {
Self::Basic {
username: _,
password,
} => password.is_some(),
Self::Bearer { token } => !token.is_empty(),
}
}

pub(crate) fn is_empty(&self) -> bool {
match self {
Self::Basic { username, password } => username.is_none() && password.is_none(),
Expand Down
6 changes: 3 additions & 3 deletions crates/uv-auth/src/middleware.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ impl Middleware for AuthMiddleware {
request = credentials.authenticate(request);

// If it's fully authenticated, finish the request
if credentials.password().is_some() {
if credentials.is_authenticated() {
trace!("Request for {url} is fully authenticated");
return self
.complete_request(None, request, extensions, next, auth_policy)
Expand Down Expand Up @@ -420,7 +420,7 @@ impl Middleware for AuthMiddleware {
.or(credentials);

if let Some(credentials) = credentials.as_ref() {
if credentials.password().is_some() {
if credentials.is_authenticated() {
trace!("Retrying request for {url} with credentials from cache {credentials:?}");
retry_request = credentials.authenticate(retry_request);
return self
Expand Down Expand Up @@ -529,7 +529,7 @@ impl AuthMiddleware {
let credentials = Arc::new(credentials);

// If there's a password, send the request and cache
if credentials.password().is_some() {
if credentials.is_authenticated() {
trace!("Request for {url} already contains username and password");
return self
.complete_request(Some(credentials), request, extensions, next, auth_policy)
Expand Down
Loading