Skip to content

Consistently use Ordering::Relaxed for standalone atomic use cases #14190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oconnor663 merged 4 commits into from
Jun 24, 2025
Merged

Consistently use Ordering::Relaxed for standalone atomic use cases #14190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9fe2e70
Use Relaxed memory ordering
christeefy Jun 21, 2025
fde9083
Re-trigger CI
christeefy Jun 22, 2025
3646bdf
Update memory ordering for RAYON_PARALLELISM
christeefy Jun 23, 2025
993ca5c
Re-trigger CI
christeefy Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/uv-configuration/src/threading.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pub static RAYON_PARALLELISM: AtomicUsize = AtomicUsize::new(0);
/// `LazyLock::force(&RAYON_INITIALIZE)`.
pub static RAYON_INITIALIZE: LazyLock<()> = LazyLock::new(|| {
rayon::ThreadPoolBuilder::new()
.num_threads(RAYON_PARALLELISM.load(Ordering::SeqCst))
.num_threads(RAYON_PARALLELISM.load(Ordering::Relaxed))
.stack_size(min_stack_size())
.build_global()
.expect("failed to initialize global rayon pool");
Expand Down
8 changes: 4 additions & 4 deletions crates/uv-warnings/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ pub static ENABLED: AtomicBool = AtomicBool::new(false);

/// Enable user-facing warnings.
pub fn enable() {
ENABLED.store(true, std::sync::atomic::Ordering::SeqCst);
ENABLED.store(true, std::sync::atomic::Ordering::Relaxed);
}

/// Disable user-facing warnings.
pub fn disable() {
ENABLED.store(false, std::sync::atomic::Ordering::SeqCst);
ENABLED.store(false, std::sync::atomic::Ordering::Relaxed);
}

/// Warn a user, if warnings are enabled.
Expand All @@ -28,7 +28,7 @@ macro_rules! warn_user {
use $crate::anstream::eprintln;
use $crate::owo_colors::OwoColorize;

if $crate::ENABLED.load(std::sync::atomic::Ordering::SeqCst) {
if $crate::ENABLED.load(std::sync::atomic::Ordering::Relaxed) {
let message = format!("{}", format_args!($($arg)*));
let formatted = message.bold();
eprintln!("{}{} {formatted}", "warning".yellow().bold(), ":".bold());
Expand All @@ -46,7 +46,7 @@ macro_rules! warn_user_once {
use $crate::anstream::eprintln;
use $crate::owo_colors::OwoColorize;

if $crate::ENABLED.load(std::sync::atomic::Ordering::SeqCst) {
if $crate::ENABLED.load(std::sync::atomic::Ordering::Relaxed) {
if let Ok(mut states) = $crate::WARNINGS.lock() {
let message = format!("{}", format_args!($($arg)*));
if states.insert(message.clone()) {
Expand Down
2 changes: 1 addition & 1 deletion crates/uv/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ async fn run(mut cli: Cli) -> Result<ExitStatus> {
}))?;

// Don't initialize the rayon threadpool yet, this is too costly when we're doing a noop sync.
uv_configuration::RAYON_PARALLELISM.store(globals.concurrency.installs, Ordering::SeqCst);
uv_configuration::RAYON_PARALLELISM.store(globals.concurrency.installs, Ordering::Relaxed);

debug!("uv {}", uv_cli::version::uv_self_version());

Expand Down
Loading