Conversation
d57dd8f to
215e68d
Compare
eifinger
left a comment
There was a problem hiding this comment.
I would rather not spread this functionality over the code if not necessary and avoid setting env vars.
We can also solve this by making use of the fact that cache.restoreCache and cache.saveCache accept more than one path.
Before running the actions determine if cachePython is true and then determine the pythonDir by capturing the output of uv python dir.
Also add another segment to the cache key to show if cachePython is set.
Finally lets also test this with a test in test.yml. e.g. Setting up the cache, restoring the cache and check if the required files are in the expected dir.
92e3b5d to
e4538f5
Compare
|
Almost ready, just need to figure out why the test is failing. |
a9a125f to
a2f443f
Compare
eifinger
left a comment
There was a problem hiding this comment.
I see you are iterating to get the test to pass. Some comments that might help.
a2f443f to
55e2d80
Compare
fe551dd to
08df9dc
Compare
3d68f99 to
c8d10d1
Compare
eifinger
left a comment
There was a problem hiding this comment.
This looks really nice. Great work. Thank you!
Small typo and we are good to go. But already leaving an approval. Will release this tomorrow.
Co-authored-by: Kevin Stillhammer <[email protected]>
This pull request introduces support for caching Python installs in the GitHub Action, allowing users to cache not only dependencies but also the Python interpreter itself.
This works by setting theUV_PYTHON_INSTALL_DIRto a subdirectory of the dependency cache path so that Python installs are directed there.Fixes #135