Fix range of unparenthesized tuple subject in match statement #8101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
force-pushed
the
charlie/match
branch
from
f83e6f9 to
e1f2995
Compare
charliermarsh
added
bug
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
MichaReiser
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This was just a bug in the parser ranges, probably since it was initially implemented. Given
match n % 3, n % 5: ..., the "subject" (i.e., the tuple of two binary operators) was using the entire range of thematchstatement.Closes #8091.
Test Plan
cargo test