Skip to content

Fix message for too-many-arguments lint #8092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
charliermarsh merged 4 commits into from
Oct 20, 2023
Merged

Fix message for too-many-arguments lint #8092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e923a8
Fix message for `too-many-arguments` lint
flying-sheep Oct 20, 2023
d445e3a
Fix tests
flying-sheep Oct 20, 2023
b67d067
Update crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs
flying-sheep Oct 20, 2023
04de4cd
fix tests again
flying-sheep Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ruff_linter/src/rules/pylint/rules/too_many_arguments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ impl Violation for TooManyArguments {
#[derive_message_formats]
fn message(&self) -> String {
let TooManyArguments { c_args, max_args } = self;
format!("Too many arguments to function call ({c_args} > {max_args})")
format!("Too many arguments in function definition ({c_args} > {max_args})")
}
}

Expand Down
10 changes: 5 additions & 5 deletions ...es/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR0913_too_many_arguments.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,35 +1,35 @@
---
source: crates/ruff_linter/src/rules/pylint/mod.rs
---
too_many_arguments.py:1:5: PLR0913 Too many arguments to function call (8 > 5)
too_many_arguments.py:1:5: PLR0913 Too many arguments in function definition (8 > 5)
|
1 | def f(x, y, z, t, u, v, w, r): # Too many arguments (8/5)
| ^ PLR0913
2 | pass
|

too_many_arguments.py:17:5: PLR0913 Too many arguments to function call (6 > 5)
too_many_arguments.py:17:5: PLR0913 Too many arguments in function definition (6 > 5)
|
17 | def f(x, y, z, u=1, v=1, r=1): # Too many arguments (6/5)
| ^ PLR0913
18 | pass
|

too_many_arguments.py:25:5: PLR0913 Too many arguments to function call (6 > 5)
too_many_arguments.py:25:5: PLR0913 Too many arguments in function definition (6 > 5)
|
25 | def f(x, y, z, /, u, v, w): # Too many arguments (6/5)
| ^ PLR0913
26 | pass
|

too_many_arguments.py:29:5: PLR0913 Too many arguments to function call (6 > 5)
too_many_arguments.py:29:5: PLR0913 Too many arguments in function definition (6 > 5)
|
29 | def f(x, y, z, *, u, v, w): # Too many arguments (6/5)
| ^ PLR0913
30 | pass
|

too_many_arguments.py:33:5: PLR0913 Too many arguments to function call (9 > 5)
too_many_arguments.py:33:5: PLR0913 Too many arguments in function definition (9 > 5)
|
33 | def f(x, y, z, a, b, c, *, u, v, w): # Too many arguments (9/5)
| ^ PLR0913
Expand Down
4 changes: 2 additions & 2 deletions ...s/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__max_args.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
source: crates/ruff_linter/src/rules/pylint/mod.rs
---
too_many_arguments_params.py:3:5: PLR0913 Too many arguments to function call (6 > 4)
too_many_arguments_params.py:3:5: PLR0913 Too many arguments in function definition (6 > 4)
|
1 | # Too many args (6/4) for max_args=4
2 | # OK for dummy_variable_rgx ~ "skip_.*"
Expand All @@ -10,7 +10,7 @@ too_many_arguments_params.py:3:5: PLR0913 Too many arguments to function call (6
4 | pass
|

too_many_arguments_params.py:9:5: PLR0913 Too many arguments to function call (6 > 4)
too_many_arguments_params.py:9:5: PLR0913 Too many arguments in function definition (6 > 4)
|
7 | # Too many args (6/4) for max_args=4
8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*"
Expand Down
2 changes: 1 addition & 1 deletion ...es/pylint/snapshots/ruff_linter__rules__pylint__tests__max_args_with_dummy_variables.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
source: crates/ruff_linter/src/rules/pylint/mod.rs
---
too_many_arguments_params.py:9:5: PLR0913 Too many arguments to function call (6 > 5)
too_many_arguments_params.py:9:5: PLR0913 Too many arguments in function definition (6 > 5)
|
7 | # Too many args (6/4) for max_args=4
8 | # Too many args (6/5) for dummy_variable_rgx ~ "skip_.*"
Expand Down