Move typos to pre-commit config#4148
Merged
charliermarsh merged 4 commits intoastral-sh:mainfrom Apr 29, 2023
Merged
Conversation
Contributor
PR Check ResultsEcosystem✅ ecosystem check detected no changes. BenchmarkLinuxWindows |
Member
|
Thanks! Any idea why those weren't being identified before? |
Contributor
Author
I'm not sure I'm afraid. I have only used the pre-commit version before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For users of pre-commit, it would be useful to add the typos pre-commit check that currently runs in CI. With this proposed change, CI would run the typos check twice (in the pre-commit stage and its own stage), which is not necessary.
Moving typos to pre-commit also identified a couple of typos that were not picked up with the original CI version of the tool. One that was fixed in blacks test cases in psf/black#3599 and one that is not considered a typo in black that has been added to
_typos.toml.