Update pre-commit hook name #19530
Merged
Update pre-commit hook name #19530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
approved these changes
Jul 24, 2025
UnboundVariable
pushed a commit
to UnboundVariable/ruff
that referenced
this pull request
Jul 24, 2025
…hlight * 'main' of https://github.com/astral-sh/ruff: [ty] Minor: fix incomplete docstring (astral-sh#19534) [ty] Move server tests as integration tests (astral-sh#19522) [`ruff`] Offer fixes for `RUF039` in more cases (astral-sh#19065) [ty] Support `dataclasses.InitVar` (astral-sh#19527) [`ruff`] Fix `RUF033` breaking with named default expressions (astral-sh#19115) Update pre-commit hook name (astral-sh#19530) Bump 0.12.5 (astral-sh#19528) [ty] Rename type_api => ty_extensions (astral-sh#19523) [ty] Added support for "go to references" in ty playground. (astral-sh#19516) [ty] Return a tuple spec from the iterator protocol (astral-sh#19496) [ty] Exhaustiveness checking & reachability for `match` statements (astral-sh#19508) [ty] Fix narrowing and reachability of class patterns with arguments (astral-sh#19512)
UnboundVariable
pushed a commit
to UnboundVariable/ruff
that referenced
this pull request
Jul 24, 2025
* main: [ty] Added support for "document highlights" language server feature. (astral-sh#19515) Add support for specifying minimum dots in detected string imports (astral-sh#19538) [ty] Minor: fix incomplete docstring (astral-sh#19534) [ty] Move server tests as integration tests (astral-sh#19522) [`ruff`] Offer fixes for `RUF039` in more cases (astral-sh#19065) [ty] Support `dataclasses.InitVar` (astral-sh#19527) [`ruff`] Fix `RUF033` breaking with named default expressions (astral-sh#19115) Update pre-commit hook name (astral-sh#19530) Bump 0.12.5 (astral-sh#19528) [ty] Rename type_api => ty_extensions (astral-sh#19523) [ty] Added support for "go to references" in ty playground. (astral-sh#19516) # Conflicts: # crates/ty_server/src/server/api/requests.rs # crates/ty_server/tests/e2e/snapshots/e2e__initialize__initialization.snap # crates/ty_server/tests/e2e/snapshots/e2e__initialize__initialization_with_workspace.snap
AlexWaygood
pushed a commit
that referenced
this pull request
Jul 25, 2025
## Summary A couple of months ago now (astral-sh/ruff-pre-commit#124) we changed the hook ID from just `ruff` to `ruff-check` to mirror `ruff-format`. I noticed the `ruff (legacy alias)` when running pre-commit on the release today and realized we should probably update. ## Test Plan Commit on this PR: ```shell > git commit -m "Update pre-commit hook name" check for merge conflicts................................................Passed Validate pyproject.toml..............................(no files to check)Skipped mdformat.............................................(no files to check)Skipped markdownlint-fix.....................................(no files to check)Skipped blacken-docs.........................................(no files to check)Skipped typos....................................................................Passed cargo fmt............................................(no files to check)Skipped ruff format..........................................(no files to check)Skipped ruff check...........................................(no files to check)Skipped <-- prettier.................................................................Passed zizmor...............................................(no files to check)Skipped Validate GitHub Workflows............................(no files to check)Skipped shellcheck...........................................(no files to check)Skipped ``` Compared to the release branch: ```shell > pre-commit run ... cargo fmt............................................(no files to check)Skipped ruff format..........................................(no files to check)Skipped ruff (legacy alias)..................................(no files to check)Skipped ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A couple of months ago now (astral-sh/ruff-pre-commit#124) we changed the hook ID from just
rufftoruff-checkto mirrorruff-format. I noticed theruff (legacy alias)when running pre-commit on the release today and realized we should probably update.Test Plan
Commit on this PR:
Compared to the release branch:
> pre-commit run ... cargo fmt............................................(no files to check)Skipped ruff format..........................................(no files to check)Skipped ruff (legacy alias)..................................(no files to check)Skipped ...