Skip to content

Conversation

@danparizher
Copy link
Contributor

Summary

Fixes #19305

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+0 -16 violations, +0 -0 fixes in 2 projects; 53 projects unchanged)

apache/airflow (+0 -10 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

- airflow-core/tests/unit/decorators/test_mapped.py:34:13: FURB118 Use `operator.add` instead of defining a function
- airflow-core/tests/unit/ti_deps/deps/test_mapped_task_upstream_dep.py:113:13: FURB118 Use `operator.add` instead of defining a function
- airflow-core/tests/unit/ti_deps/deps/test_mapped_task_upstream_dep.py:199:13: FURB118 Use `operator.add` instead of defining a function
- providers/amazon/tests/system/amazon/aws/example_ec2.py:105:5: FURB118 Use `operator.itemgetter(0)` instead of defining a function
- providers/amazon/tests/system/amazon/aws/example_emr.py:128:5: FURB118 Use `operator.itemgetter(0)` instead of defining a function
- providers/amazon/tests/unit/amazon/aws/hooks/test_rds.py:104:5: FURB118 Use `operator.itemgetter("DBClusterSnapshotIdentifier")` instead of defining a function
- providers/amazon/tests/unit/amazon/aws/hooks/test_rds.py:82:5: FURB118 Use `operator.itemgetter("DBSnapshotIdentifier")` instead of defining a function
- providers/amazon/tests/unit/amazon/aws/hooks/test_rds.py:87:5: FURB118 Use `operator.itemgetter("DBSnapshotArn")` instead of defining a function
- providers/standard/tests/unit/standard/decorators/test_python.py:742:9: FURB118 Use `operator.mul` instead of defining a function
- task-sdk/tests/task_sdk/definitions/test_mappedoperator.py:526:9: FURB118 Use `operator.add` instead of defining a function

astropy/astropy (+0 -6 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

- astropy/io/fits/hdu/compressed/tests/conftest.py:100:5: FURB118 Use `operator.itemgetter(1)` instead of defining a function
- astropy/io/fits/hdu/compressed/tests/conftest.py:105:5: FURB118 Use `operator.itemgetter(2)` instead of defining a function
- astropy/io/fits/hdu/compressed/tests/conftest.py:95:5: FURB118 Use `operator.itemgetter(0)` instead of defining a function
- astropy/io/fits/hdu/compressed/tests/test_fitsio.py:90:5: FURB118 Use `operator.itemgetter(1)` instead of defining a function
- astropy/io/fits/hdu/compressed/tests/test_fitsio.py:95:5: FURB118 Use `operator.itemgetter(0)` instead of defining a function
- astropy/modeling/tests/test_separable.py:189:9: FURB118 Use `operator.add` instead of defining a function

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
FURB118 16 0 16 0 0

@ntBre ntBre self-requested a review July 15, 2025 16:55
@ntBre ntBre added bug Something isn't working rule Implementing or modifying a lint rule labels Jul 15, 2025
@dylwil3 dylwil3 changed the title [refurb] Ignore decorated functions for FURB118 [refurb] Ignore decorated functions for FURB118 Jul 25, 2025
Copy link
Collaborator

@dylwil3 dylwil3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@dylwil3 dylwil3 merged commit 3e366fd into astral-sh:main Jul 25, 2025
37 checks passed
@danparizher danparizher deleted the fix-19305 branch July 25, 2025 15:43
AlexWaygood pushed a commit that referenced this pull request Jul 25, 2025
dcreager added a commit that referenced this pull request Jul 25, 2025
* main:
  [ty] Added support for "document symbols" and "workspace symbols" (#19521)
  Add `TextEmitter::with_color` and disable colors in `unreadable_files` test (#19562)
  [ty] Added support for document highlights in playground. (#19540)
  [`refurb`] Ignore decorated functions for `FURB118` (#19339)
  [ty] Add workflow to comment diagnostic diff for conformance tests (#19556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FURB118: false positive for pytest fixture

3 participants