Skip to content

[ty] Simplify signature types, use them in CallableType #18344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 28, 2025
Merged

[ty] Simplify signature types, use them in CallableType #18344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e45b7fb
Move stuff from sig to bindings
dcreager May 27, 2025
009950b
Use signature in callable
dcreager May 27, 2025
8769d93
Remove signatures
dcreager May 27, 2025
3e1cec4
Merge branch 'main' into dcreager/dunder-call
dcreager May 28, 2025
59ff2d9
Update comment
dcreager May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
690 changes: 289 additions & 401 deletions crates/ty_python_semantic/src/types.rs
View file
Open in desktop
Copy link
Member Author

@dcreager dcreager May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff of this file is less chatty if you hide whitespace

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions crates/ty_python_semantic/src/types/call.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
use super::context::InferContext;
use super::{CallableSignature, Signature, Signatures, Type};
use super::{Signature, Type};
use crate::Db;

mod arguments;
mod bind;
pub(super) use arguments::{Argument, CallArgumentTypes, CallArguments};
pub(super) use bind::{Bindings, CallableBinding};
pub(super) use bind::{Binding, Bindings, CallableBinding};

/// Wraps a [`Bindings`] for an unsuccessful call with information about why the call was
/// unsuccessful.
Expand Down
Loading
Loading