[syntax-errors] Use consistent message for bad starred expression usage. #17772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijeetbodas2001
requested review from
MichaReiser and
dhruvmanila
as code owners
Contributor
Author
|
cc @ntBre |
Contributor
|
ntBre
approved these changes
May 1, 2025
Contributor
ntBre
left a comment
ntBre
left a comment
There was a problem hiding this comment.
Awesome, thanks for following up! I believe this is exactly what @dhruvmanila suggested, but I'll wait to merge until he has a chance to look.
dhruvmanila
approved these changes
May 1, 2025
Member
dhruvmanila
left a comment
dhruvmanila
left a comment
There was a problem hiding this comment.
Looks good, thanks @ntBre for checking in!
dcreager
added a commit
that referenced
this pull request
May 2, 2025
* main: [red-knot] Refactor: no mutability in call APIs (#17788) [red-knot] Fix panic for `tuple[x[y]]` string annotation (#17787) [red-knot] Implicit instance attributes in generic methods (#17769) doc: Add link to `check-typed-exception` from `S110` and `S112` (#17786) Fix module name in ASYNC110, 115, and 116 fixes (#17774) [red-knot] More informative hover-types for assignments (#17762) [syntax-errors] Use consistent message for bad starred expression usage. (#17772) red_knot_server: add auto-completion MVP Allow passing a virtual environment to `ruff analyze graph` (#17743) Bump 0.11.8 (#17766) [`flake8-use-pathlib`] Fix `PTH104`false positive when `rename` is passed a file descriptor (#17712)
ntBre
added a commit
to maxmynter/ruff
that referenced
this pull request
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up from #17624, where we found that the error message sent by
SemanticSyntaxErrorKindandParseErrorTypewere different for invalid*exprusage.This PR changes the message of
SemanticSyntaxErrorKind::InvalidStarExpressionto be the same as the error message of the parser.Ref: #17624 (comment)
Test Plan
Updated existing tests.