Skip to content

Conversation

@ntBre
Copy link
Contributor

@ntBre ntBre commented Mar 11, 2025

Summary

Stabilizes RUF046 and moves its test to the right place. The docs look good.

Test Plan

2 closed newline/whitespace issues from early January and 1 closed issue about really being multiple rules, but otherwise no recent issues or PRs.

Summary
--

Stabilizes RUF046 and moves its test to the right place. The docs look good.

Test Plan
--

2 closed newline/whitespace issues from early January and 1 closed issue about
really being multiple rules, but otherwise no recent issues or PRs.
@ntBre ntBre added the rule Implementing or modifying a lint rule label Mar 11, 2025
@ntBre ntBre added this to the v0.10 milestone Mar 11, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025

CodSpeed Performance Report

Merging #16649 will degrade performances by 10.81%

Comparing brent/ruf046-0.10 (149591e) with micha/ruff-0.10 (b8f1284)

Summary

❌ 1 regressions
✅ 31 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
red_knot_check_file[incremental] 4.9 ms 5.5 ms -10.81%

@github-actions
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+16 -0 violations, +0 -0 fixes in 6 projects; 49 projects unchanged)

RasaHQ/rasa (+1 -0 violations, +0 -0 fixes)

+ rasa/shared/core/training_data/loading.py:86:15: RUF046 Value being cast to `int` is already an integer

apache/superset (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ superset/migrations/versions/2018-07-22_11-59_bebcf3fed1fe_convert_dashboard_v1_positions.py:197:40: RUF046 Value being cast to `int` is already an integer
+ superset/migrations/versions/2018-07-22_11-59_bebcf3fed1fe_convert_dashboard_v1_positions.py:199:29: RUF046 Value being cast to `int` is already an integer

binary-husky/gpt_academic (+1 -0 violations, +0 -0 fixes)

+ crazy_functions/pdf_fns/parse_pdf.py:117:21: RUF046 Value being cast to `int` is already an integer

bokeh/bokeh (+5 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ examples/server/app/spectrogram/main.py:107:13: RUF046 Value being cast to `int` is already an integer
+ src/bokeh/colors/color.py:338:60: RUF046 Value being cast to `int` is already an integer
+ src/bokeh/palettes.py:1530:27: RUF046 Value being cast to `int` is already an integer
+ src/bokeh/palettes.py:1568:10: RUF046 Value being cast to `int` is already an integer
+ src/bokeh/palettes.py:1569:10: RUF046 Value being cast to `int` is already an integer

pandas-dev/pandas (+1 -0 violations, +0 -0 fixes)

+ pandas/tests/dtypes/cast/test_maybe_box_native.py:20:10: RUF046 [*] Value being cast to `int` is already an integer

astropy/astropy (+6 -0 violations, +0 -0 fixes)

+ astropy/io/fits/hdu/compressed/tests/test_compressed.py:375:26: RUF046 Value being cast to `int` is already an integer
+ astropy/io/fits/hdu/compressed/utils.py:102:13: RUF046 Value being cast to `int` is already an integer
+ astropy/io/fits/tests/test_image.py:1010:26: RUF046 Value being cast to `int` is already an integer
+ astropy/io/votable/validator/html.py:246:14: RUF046 Value being cast to `int` is already an integer
+ astropy/modeling/_fitting_parallel.py:194:22: RUF046 Value being cast to `int` is already an integer
+ astropy/utils/console.py:365:21: RUF046 Value being cast to `int` is already an integer

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF046 16 16 0 0 0

Linter (preview)

✅ ecosystem check detected no linter changes.

@ntBre
Copy link
Contributor Author

ntBre commented Mar 11, 2025

These all look like true positives to me.

@ntBre ntBre mentioned this pull request Mar 12, 2025
2 tasks
@ntBre ntBre merged commit 0ced1cb into micha/ruff-0.10 Mar 12, 2025
20 of 21 checks passed
@ntBre ntBre deleted the brent/ruf046-0.10 branch March 12, 2025 12:14
MichaReiser pushed a commit that referenced this pull request Mar 13, 2025
Summary
--

Stabilizes RUF046 and moves its test to the right place. The docs look
good.

Test Plan
--

2 closed newline/whitespace issues from early January and 1 closed issue
about really being multiple rules, but otherwise no recent issues or
PRs.
MichaReiser pushed a commit that referenced this pull request Mar 13, 2025
Summary
--

Stabilizes RUF046 and moves its test to the right place. The docs look
good.

Test Plan
--

2 closed newline/whitespace issues from early January and 1 closed issue
about really being multiple rules, but otherwise no recent issues or
PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rule Implementing or modifying a lint rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants