fix(main): handle ast-grep exit code 1 as non-error in run_command fu…#24
Merged
HerringtonDarkholme merged 1 commit intoast-grep:mainfrom Dec 17, 2025
Merged
Conversation
HerringtonDarkholme
approved these changes
Dec 17, 2025
Member
HerringtonDarkholme
left a comment
There was a problem hiding this comment.
thanks!
the change looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modified the
run_commandfunction inmain.pyto properly handle ast-grep's exit code 1, which indicates "no matches found" rather than an error condition.Changes
Error Handling Improvement
check=Truetocheck=Falseinsubprocess.run()to allow manual exit code handlingExit Code 1 Handling for ast-grep
The function now recognizes exit code 1 as valid when:
[]), or starts with[(valid JSON array)--jsonflag is not present and stdout is empty (text format with no matches)Error Reporting
CalledProcessErrorexception to explicit return code checkingRuntimeErrorfor genuine command failures (exit codes other than 0 and ast-grep's special case 1)Impact
This change prevents false error reporting when ast-grep returns no matches, which is a normal operational outcome rather than a failure condition. The function now correctly distinguishes between: