[FR]: Use typescript from npm_translate_lock

[Silic0nS0ldier]

What is the current behavior?

As of #308 the TypeScript version and integrity can be automatically extracted, however this misses out on functionality present in npm_translate_lock such as applying patches.

A recent TypeScript release included a bug microsoft/TypeScript#57849 (5.4.x, broken in 5.4.2 and fixed in 5.4.5) which was fixed with a trivial patch, however it could not be applied to Rules TS's @npm_typescript repo.

Describe the feature

Instead of pulling in TypeScript with bespoke logic

rules_ts/ts/private/npm_repositories.bzl

Line 66 in 87e3723

http_archive_version = repository_rule(

support using TypeScript from npm_translate_lock's node_modules directly. This way functionality like patching comes free.

[Silic0nS0ldier]

BTW looks like an issue workflow failed to run for this.

https://github.com/aspect-build/rules_ts/actions/runs/9394496432/job/25872315491#step:3:11

[jbedard]

I think this was solved by #418. When using the lockfile directly there might be many versions of typescript, where #418 allows specifying a specific location (just like a package_json).

[Silic0nS0ldier]

@jbedard While an improvement, it does not address my request as patches are not applied.

[jbedard]

Right, because that path still re-fetches the package?

[Silic0nS0ldier]

Refetching of the package is just an implementation detail. The problem is that patches are not applied.

(sorry for the slow reply, it was a busy few weeks)