Open
Conversation
…h-project#215) - Treat %Ash.ForbiddenField{} values as nil when dumping values for full_diff - Cover scalar and array cases in FullDiff.Helpers.dump_value/2 - Add regression tests in AshPaperTrail.FullDiffTest - Document ForbiddenField->nil behavior for :full_diff in the Resource DSL docs - Note the fix under Unreleased in the changelog
2 tasks
zachdaniel
reviewed
Dec 3, 2025
zachdaniel
requested changes
Dec 3, 2025
zachdaniel
reviewed
Dec 3, 2025
zachdaniel
reviewed
Dec 3, 2025
M-Gonzalo
commented
Dec 4, 2025
Author
|
Implemented suggestions about |
zachdaniel
reviewed
Dec 4, 2025
zachdaniel
reviewed
Dec 4, 2025
zachdaniel
reviewed
Dec 6, 2025
| true -> | ||
| regex_fallback(resource) | ||
| if safe_resource_version?(resource) do | ||
| if function_exported?(resource, :version_of, 0) do |
Contributor
There was a problem hiding this comment.
same here, you don't need it due to safe_version_of
zachdaniel
requested changes
Dec 6, 2025
Contributor
zachdaniel
left a comment
zachdaniel
left a comment
There was a problem hiding this comment.
Will merge once we remove that remaining function_exported 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.