Change to tab layout for pyproject.toml vs setup.cfg #1155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamJamieson
commented
Jun 20, 2022
zacharyburnett
approved these changes
Jun 20, 2022
Member
zacharyburnett
left a comment
zacharyburnett
left a comment
There was a problem hiding this comment.
looks good to me, I've added links to the relevant parts of the built docs for reference
| ``setup.cfg``) that identifies the method as an ``asdf.extensions`` entry point: | ||
|
|
||
| .. code-block:: toml | ||
| .. tab:: pyproject.toml |
Member
There was a problem hiding this comment.
| one with the following should be sufficient: | ||
|
|
||
| .. code:: toml | ||
| .. tab:: pyproject.toml |
Member
There was a problem hiding this comment.
| ``setup.cfg``) requesting that all files with a ``.yaml`` extension be installed: | ||
|
|
||
| .. code-block:: toml | ||
| .. tab:: pyproject.toml |
Member
There was a problem hiding this comment.
| that identifies the method as an ``asdf.resource_mappings`` entry point: | ||
|
|
||
| .. code-block:: toml | ||
| .. tab:: pyproject.toml |
Member
There was a problem hiding this comment.
WilliamJamieson
added a commit
to WilliamJamieson/asdf
that referenced
this pull request
Aug 17, 2022
* Change to tab layout for pyproject vs setup.cfg * Update changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes layout for
pyproject.tomlvssetup.cfgexamples from listing consecutively to placing them on user selectable tabs.