Skip to content

GH-877: Extract logic for generating executables from Java into scripts#887

Merged
ascopes merged 2 commits intomainfrom
task/gh-877-reusable-java-app-generator
Dec 6, 2025
Merged

GH-877: Extract logic for generating executables from Java into scripts#887
ascopes merged 2 commits intomainfrom
task/gh-877-reusable-java-app-generator

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Dec 6, 2025

Part of GH-877, to allow reusing this logic for generating a runnable executable of protoc that is managed via a WASM build of protoc later.

@ascopes ascopes self-assigned this Dec 6, 2025
@ascopes ascopes added the chore General tech debt work. label Dec 6, 2025
@codecov
Copy link

codecov bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 86.89655% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.87%. Comparing base (31a6b09) to head (b8f83d9).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...nplugin/java/JavaAppToExecutableScriptFactory.java 85.96% 11 Missing and 6 partials ⚠️
...protobufmavenplugin/plugins/JvmPluginResolver.java 91.67% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   92.88%   92.87%   -0.00%     
==========================================
  Files          72       73       +1     
  Lines        2034     2047      +13     
  Branches      131      131              
==========================================
+ Hits         1889     1901      +12     
- Misses        104      105       +1     
  Partials       41       41              
Files with missing lines Coverage Δ
...protobufmavenplugin/plugins/JvmPluginResolver.java 88.10% <91.67%> (+2.10%) ⬆️
...nplugin/java/JavaAppToExecutableScriptFactory.java 85.96% <85.96%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ascopes ascopes merged commit 190705a into main Dec 6, 2025
14 of 16 checks passed
@ascopes ascopes deleted the task/gh-877-reusable-java-app-generator branch December 6, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore General tech debt work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant