GH-877: Centralise Plexus components for consistency moving forwards#878
Merged
GH-877: Centralise Plexus components for consistency moving forwards#878
Conversation
17 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 92.67% 92.66% -0.00%
==========================================
Files 71 71
Lines 1977 1975 -2
Branches 127 127
==========================================
- Hits 1832 1830 -2
Misses 104 104
Partials 41 41
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GH-877 is likely to introduce new Plexus mechanisms and components, so this should be centralised in a common package prior to those changes such that we aim for consistency.
As part of this, converters will be wired in via CDI. There doesn't appear to be any good reason to not be doing this.