Skip to content

GH-877: Centralise Plexus components for consistency moving forwards#878

Merged
ascopes merged 3 commits intomainfrom
task/GH-877-centralise-plexus
Nov 25, 2025
Merged

GH-877: Centralise Plexus components for consistency moving forwards#878
ascopes merged 3 commits intomainfrom
task/GH-877-centralise-plexus

Conversation

@ascopes
Copy link
Owner

@ascopes ascopes commented Nov 25, 2025

GH-877 is likely to introduce new Plexus mechanisms and components, so this should be centralised in a common package prior to those changes such that we aim for consistency.

As part of this, converters will be wired in via CDI. There doesn't appear to be any good reason to not be doing this.

@ascopes ascopes self-assigned this Nov 25, 2025
@ascopes ascopes added the chore General tech debt work. label Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.66%. Comparing base (eaa8a74) to head (225bed8).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   92.67%   92.66%   -0.00%     
==========================================
  Files          71       71              
  Lines        1977     1975       -2     
  Branches      127      127              
==========================================
- Hits         1832     1830       -2     
  Misses        104      104              
  Partials       41       41              
Files with missing lines Coverage Δ
...pes/protobufmavenplugin/mojo/MainGenerateMojo.java 100.00% <ø> (ø)
...pes/protobufmavenplugin/mojo/TestGenerateMojo.java 100.00% <ø> (ø)
...tobufmavenplugin/plexus/DigestPlexusConverter.java 96.43% <100.00%> (ø)
...rotobufmavenplugin/plexus/PathPlexusConverter.java 100.00% <100.00%> (ø)
...protobufmavenplugin/plexus/PluginConfigurator.java 100.00% <100.00%> (ø)
...protobufmavenplugin/plexus/UriPlexusConverter.java 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ascopes ascopes merged commit f27922b into main Nov 25, 2025
16 checks passed
@ascopes ascopes deleted the task/GH-877-centralise-plexus branch November 25, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore General tech debt work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant