Skip to content

GH-621: Remove dead code for working directory discovery#622

Merged
ascopes merged 1 commit into
mainfrom
bugfix/gh-621-working-directory
Mar 31, 2025
Merged

GH-621: Remove dead code for working directory discovery#622
ascopes merged 1 commit into
mainfrom
bugfix/gh-621-working-directory

Conversation

@ascopes

@ascopes ascopes commented Mar 31, 2025

Copy link
Copy Markdown
Owner

Closes GH-621.

Originally this was going to be a bugfix to handle the working directory correctly when calling mvn -f but this appears to be totally dead code anyway, so I am just removing it.

@ascopes ascopes added the chore General tech debt work. label Mar 31, 2025
@ascopes ascopes added this to the v3.0.x milestone Mar 31, 2025
@ascopes ascopes self-assigned this Mar 31, 2025
@ascopes ascopes merged commit e333aeb into main Mar 31, 2025
@ascopes ascopes deleted the bugfix/gh-621-working-directory branch March 31, 2025 06:05
@codecov

codecov Bot commented Mar 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.99%. Comparing base (bb465d3) to head (fd2af94).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   91.00%   90.99%   -0.01%     
==========================================
  Files          48       48              
  Lines        1499     1497       -2     
  Branches      100      100              
==========================================
- Hits         1364     1362       -2     
  Misses         99       99              
  Partials       36       36              
Files with missing lines Coverage Δ
.../ascopes/protobufmavenplugin/utils/HostSystem.java 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore General tech debt work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore]: working directory is not used

1 participant