refactor(use-case/ajaxapp): サンプルコードのディレクトリをexampleに移動 #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for js-primer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
azu
reviewed
Dec 7, 2022
azu
reviewed
Dec 7, 2022
|
|
||
| 次に同じディレクトリに`index.js`というファイルを作成します。 | ||
| `index.js`にはスクリプトが正しく読み込まれたことを確認できるよう、コンソールにログを出力する処理だけを書いておきます。 | ||
| 次に、`src`というディレクトリを作成し、その中に`index.js`というファイルを作成します。 |
Collaborator
There was a problem hiding this comment.
index.js が src/index.js を示すようになってちょっとややこしさを感じる。
https://deploy-preview-1538--js-primer.netlify.app/use-case/todoapp/
Todoだとindex.htmlとindex.js同じ場所においてたんだよねー
Collaborator
Author
There was a problem hiding this comment.
あれ、そうですっけ todoappのほうでsrcに入れてたと思って合わせたつもりだった なくて良さそうなら無くします
Collaborator
Author
|
jsファイルのsrcディレクトリは消す（テスト対象のglobに使ってなかったかを確認する） |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1532