Skip to content

Add a close method to InferenceData #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OriolAbril merged 3 commits into from
Apr 4, 2024
Merged

Add a close method to InferenceData #2338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f66e59
Add a close method to InferenceData
lucianopaz Apr 4, 2024
5be00c5
Call InferenceData.close when an InferenceData object gets gc'ed
lucianopaz Apr 4, 2024
4ce5550
add to docs and changelog, remove del method
OriolAbril Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Add new example data `rugby_field` and update `rugby` example data ([2322](https://github.com/arviz-devs/arviz/pull/2322))
- Support for `pytree`s and robust to nested dictionaries. ([2291](https://github.com/arviz-devs/arviz/pull/2291))
- Add `.close` method to `InferenceData` ([2338](https://github.com/arviz-devs/arviz/pull/2338))


### Maintenance and fixes
Expand Down
1 change: 1 addition & 0 deletions arviz/data/inference_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1689,6 +1689,7 @@ def extend(self, other, join="left"):
compute = _extend_xr_method(xr.Dataset.compute)
persist = _extend_xr_method(xr.Dataset.persist)
quantile = _extend_xr_method(xr.Dataset.quantile)
close = _extend_xr_method(xr.Dataset.close)

# The following lines use methods on xr.Dataset that are dynamically defined and attached.
# As a result mypy cannot see them, so we have to suppress the resulting mypy errors.
Expand Down
1 change: 1 addition & 0 deletions doc/source/api/inference_data.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ IO / Conversion
InferenceData.from_zarr
InferenceData.to_zarr
InferenceData.chunk
InferenceData.close
InferenceData.compute
InferenceData.load
InferenceData.persist
Expand Down