Add support for remaining simple types.#5
Open
HugoNikanor wants to merge 3 commits intoartyom-poptsov:masterfrom
Open
Add support for remaining simple types.#5HugoNikanor wants to merge 3 commits intoartyom-poptsov:masterfrom
HugoNikanor wants to merge 3 commits intoartyom-poptsov:masterfrom
Conversation
added 3 commits
February 6, 2022 20:57
* libguile-dbus/dbus-message-func.c: Add remaining primitive datatypes when appending arguments, and error on any non-implemented type.
Prevously the code assumed that dbus_message_iter_has_next returned TRUE if a value was available, but it actually retured TRUE if more values where available, following the current value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As written, this merge request adds support for remaining simple DBus data-types, but only in some contexts. The problem with going all the way is due to Guile DBus not having a clear type definition for complex types, which I have started the discussion about over at #4.