Conversation
mutherr
left a comment
There was a problem hiding this comment.
Overall this looks good, the tests look extremely thorough and the filters seem to behave well in my local testing.
However, I'm not sure the filters are being loaded from the url properly. If I try to navigate to http://localhost:5173/index1?page=1&Classification=Species&Crystal+system=Monoclinic (the page I arrive at after checking the first filter in the first group, it takes me to http://localhost:5173/index1?page=1&Classification=Species, the unfiltered species search page. If this is functionality we care about, maybe we should make sure it still works in the new filter system?
Yeah, I noticed a little while ago that we had lost refresh stability. You can see the same behavior on Tsumeb now. We should fix it, but this PR did not introduce it. |
|
Oh yeah I see what you mean. hmm |
mutherr
left a comment
There was a problem hiding this comment.
Ok, now everything seems good. Thanks for the tests!
Change Summary
This PR adds support for grouping filters in both collapsible and non-collapsible groups. It is not a breaking change since the
filtersDefinitionwill be parsed for a flat definition if it is an object, but if it is an array then it will be parsed as an array of filter groupings. I included animations for the collapse and expand actions.There are also a few customization updates such as making the search bar part of an overridable slot.
The logic here was tricky, so I have added a lot of tests (with lots of help from Sonnet 4, especially around the mock data).
Related issue number
Jira DAR-1228
PR Type
Engineer Checklist
Dev -> ProdPR or open that PR if necessary. This helps us track the contents of production deploys.developtomainPR.