Apply regex change to address DoS vulnerability #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a stop-gap measure to patch a known vulnerability with the version of three we currently use in bootstrap. We'll work on updating and using the latest publicly-available version once we have time to deal with the breaking changes it brings with it.
appakz
changed the title
jameswelle
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stop-gap measure to patch a known vulnerability with the version of three we currently use in bootstrap. We'll work on updating and using the latest publicly-available version once we have time to deal with the breaking changes it brings with it.
@rockhymas @jameswelle I created an
articulatebranch on this fork that points to the release tag for the version we currently use, and opened this PR against that branch. This just applies the updated regular expressions to patch the vulnerability. We'll update our package reference in bootstrap to consume this package directly from the resulting commit on thearticulatebranch after merging this.