Upgrade SAI API version from 1.9.0 to 1.12.0#19
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Upgrade SAI API version from 1.9.0 to 1.12.0#19devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- Update minimum SAI version in configure.ac compile-time check - Update minimum SAI version in syncd/VendorSai.cpp runtime check - Update SAI submodule to v1.12.0 for full struct binary backward compatibility This change implements the recommendation in configure.ac comments to upgrade to SAI v1.12.0 for better binary compatibility, particularly for next hop group API and ACL capability data structures. Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Upgrade SAI API version from 1.9.0 to 1.12.0
Summary
This PR upgrades the minimum required SAI (Switch Abstraction Interface) API version from 1.9.0 to 1.12.0 across the codebase. The upgrade implements the recommendation documented in
configure.ac(lines 250-263) to use SAI v1.12.0 for full struct binary backward compatibility, particularly for next hop group API and ACL capability data structures.Changes made:
configure.ac(line 264)syncd/VendorSai.cpp(line 135)Review & Testing Checklist for Human
3ff228a7corresponds to the v1.12.0 tag in the SAI repositoryVendorSai::apiInitialize()correctly rejects libraries below v1.12.0Test Plan
Notes
configure.accommentsDevin Session: https://app.devin.ai/sessions/0979f12bbd0b4b77bb43d95518d9873b
Requested by: Arthur Poon (@arthurkkp-cog)