Fix digital object load and summary messages (#2345)#2356
Open
ShrishtyJainTech wants to merge 2 commits into
Open
Fix digital object load and summary messages (#2345)#2356ShrishtyJainTech wants to merge 2 commits into
ShrishtyJainTech wants to merge 2 commits into
Conversation
anvit
requested changes
May 15, 2026
| @@ -374,7 +374,7 @@ protected function addDigitalObject($objectId, $path, $options = []) | |||
|
|
|||
| $remainingImportCount = $this->totalObjCount - $this->skippedCount - $importedCount; | |||
Contributor
There was a problem hiding this comment.
Remove $importedCount here since it's always going to be zero and is unused.
Author
There was a problem hiding this comment.
Updated as suggested. Please take another look when convenient.
| } | ||
|
|
||
| $this->logSection('digital-object', 'Successfully Loaded '.self::$count.' digital objects.'); | ||
| $this->logSection('digital-object', 'Successfully Loaded '.self::$count.' digital objects and skipped '.$this->skippedCount.'.'); |
Contributor
There was a problem hiding this comment.
I missed the last bit of the discussion in the morning, but I thought we'd talked about displaying the total count as well? So something along the lines of Successfully loaded 10 out of 15 digital objects, and skipped 5? Feel free to ignore this if you and Jay decided that we don't need to display that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.