Fix REST API digital object downloads#2354
Open
sevein wants to merge 1 commit into
Open
Conversation
Return the digital object download marker from the action and stream the file contents directly. The previous code passed readfile() into setContent(), which mixed immediate output with Symfony response content handling and stored the byte count returned by readfile() as response content. Mark the Symfony response as header-only after readfile() so the final rendering filter does not send response content after the file body has already been emitted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the digital object download marker from the action and stream the file contents directly. The previous code passed readfile() into setContent(), which mixed immediate output with Symfony response content handling and stored the byte count returned by readfile() as response content.
Mark the Symfony response as header-only after readfile() so the final rendering filter does not send response content after the file body has already been emitted.