Speed up install fixture loading#2352
Open
sevein wants to merge 1 commit into
Open
Conversation
Avoid recomputing access warning translations for every rights basis term during install/purge. Translate the warning strings in one batched pass and reuse the results for each generated access-statement setting. Keep QubitI18N::getTranslations() as a fresh lookup for compatibility, and add a batched helper for callers that need multiple strings translated across all languages. Also fix a stray leading '-' before the fixture loader object reference check. Measured tools:purge --demo improving from about 54s before this optimization pass to about 10s after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been finding the installer a bit slow in my local development environment, likely made more noticeable by shared-volume filesystem overhead. While profiling
tools:purge --demo, I found a couple of small fixture-loading fixes that significantly reduce the time spent loading the initial data during install/purge.Measured
tools:purge --demoimproving from about 54s before this optimization pass to about 10s after it. This is more noticeable on slower shared filesystems, but it still avoids repeated i18n work on faster environments too.